Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI 분류 시 PostKeyword 데이터도 같이 생성 및 적용 #60

Merged
merged 21 commits into from
Jul 23, 2024

Conversation

Marades
Copy link
Collaborator

@Marades Marades commented Jul 17, 2024

PR 내용

  • AI 분류 시 디스코드 알림 가게 작업
  • AI 분류 시 PostKeywod 생성하게 작업
  • post 목록에서 keyword 같이 내려주기
  • post 목록에 createdAt 추가
  • folder list 임시코드 수정
  • 에러 발생 시 디스코드 알림
  • 커스텀 post, folder 초기화 api
  • AI Handler 로직 재활용/테스트 편하게 분리
  • 폴더 내 링크 목록 정렬 적용

추가 및 변경 사항

API endpoint와 추가 혹은 변경된 사항을 적어주세요!

PR 중점사항

리뷰어가 중점적으로 봐야하는 부분에 대해 적어주세요!
작업하다보니 영향범위가 많이 커졌네..ㅎ 담부턴 잘 쪼개 하겟슴다

스크린샷

알림 스크린샷
image
image

@Marades Marades self-assigned this Jul 17, 2024
@github-actions github-actions bot added document 문서화 관련 작업 수정 및 생성 feature labels Jul 17, 2024
Comment on lines 105 to 112
this.discordProvider.send(
[
`AI 요약 실행 시간: ${elapsedTime}ms`,
`Input : ${content} / [${folderList.join(', ')}]`,
`Output : ${promptResult} `,
].join('\n'),
);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

링크도 같이 주는건 어렵겠징
요약 서버로 안넘어오니까??

Copy link
Collaborator

@hye-on hye-on Jul 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

컨텐츠의 링크랑, 요약 결과, 사용자 폴더 시간 으로 결정

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영 완료

Copy link
Collaborator

@hye-on hye-on left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생해써!!!! 👍

Copy link
Collaborator

@J-Hoplin J-Hoplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무 고생했어 형!! 👍👍

event.postContent,
folderNames,
);
export const handler: Handler = async (event: AiClassificationPayload) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아용~~!!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 AI Handler 내에 있던 코드들을 따로 모듈로 뺏구나 이것도 괜찮은거같아!! 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

응응 ai 요약책임은 저기서 전담하게끔 했으

Copy link
Collaborator

@J-Hoplin J-Hoplin Jul 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

〆(・∀・@)
형 DTO를 인터페이스로 하게되면 스웨거에서 타입 캐칭을 못해서 class로 바꿔주는거 어때??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오키 이따 반영핯앵

Copy link
Member

@JonghunAn JonghunAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 고생했어~
내가 고친부분들이랑 충돌이 있었을텐데 없길래 봤더니
PR이 dev-deploy 브랜치에 넣어뒀더라... ㅎㅎㅎ develop으로 merge 부탁해!
아마 develop이랑 merge하면 충돌 꽤 있을듯...
@Marades

@JonghunAn JonghunAn changed the base branch from dev-deploy to develop July 21, 2024 03:37
Comment on lines 116 to 125
@Delete('/all')
async removeAll(@Query() deleteCustomFolderDto: DeleteCustomFolderDto) {
await this.postsService.removeAllPostsInCustomFolders(
deleteCustomFolderDto.userId,
);
await this.foldersService.removeAllCustomFolders(
deleteCustomFolderDto.userId,
);
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(˵ •̀ ᴗ - ˵ ) ✧
ai classification도 삭제해줘야 할듯!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추가완!

@JonghunAn
Copy link
Member

DELETE folders/{folder_id} folder 삭제 시

  • post는 기존 방식대로 hard-delete
  • classification은 soft-delete

DELETE folders/all folder 전체 삭제 시

  • classification은 폴더 삭제 시 삭제되는 customFolderIdList받아서 suggestedFolderId에 포함되는 row soft-delete

@Marades Marades merged commit 0d231e5 into develop Jul 23, 2024
@J-Hoplin J-Hoplin deleted the feat/apply-post-keywords branch July 28, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document 문서화 관련 작업 수정 및 생성 feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants